[webkit-reviews] review granted: [Bug 198046] [CMake] Use target oriented design for bmalloc : [Attachment 370264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 12:00:21 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 198046: [CMake] Use target oriented design for bmalloc
https://bugs.webkit.org/show_bug.cgi?id=198046

Attachment 370264: Patch

https://bugs.webkit.org/attachment.cgi?id=370264&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370264
  --> https://bugs.webkit.org/attachment.cgi?id=370264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370264&action=review

Now we're cooking.

> Source/bmalloc/CMakeLists.txt:163
> +add_library(WebKit::bmalloc ALIAS bmallocFramework)

Why is this alias necessary or helpful?


More information about the webkit-reviews mailing list