[webkit-reviews] review granted: [Bug 198037] [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared : [Attachment 370249] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 198037: [GLIB] Crash when instantiating a js object registered with
jsc_context_register_class on window object cleared
https://bugs.webkit.org/show_bug.cgi?id=198037

Attachment 370249: Patch

https://bugs.webkit.org/attachment.cgi?id=370249&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370249
  --> https://bugs.webkit.org/attachment.cgi?id=370249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370249&action=review

> Source/JavaScriptCore/API/glib/JSCClass.cpp:346
> -	       static_cast<GParamFlags>(WEBKIT_PARAM_READWRITE |
G_PARAM_CONSTRUCT_ONLY)));
> +	       static_cast<GParamFlags>(WEBKIT_PARAM_WRITABLE |
G_PARAM_CONSTRUCT_ONLY)));

Nothing like a good API break to make a change exciting.

I think we can get away with this, though.