[webkit-reviews] review granted: [Bug 197971] GLContextEGL should check the supported EGL version at compile time : [Attachment 370161] Fix to check the EGL version at compile time

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Mads
<madhurkiran.h at gmail.com>'s request for review:
Bug 197971: GLContextEGL should check the supported EGL version at compile time
https://bugs.webkit.org/show_bug.cgi?id=197971

Attachment 370161: Fix to check the EGL version at compile time

https://bugs.webkit.org/attachment.cgi?id=370161&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370161
  --> https://bugs.webkit.org/attachment.cgi?id=370161
Fix to check the EGL version at compile time

View in context: https://bugs.webkit.org/attachment.cgi?id=370161&action=review

OK this looks better, thanks!

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:419
>	   } else if (platformDisplay.eglCheckVersion(1, 4)) {
> +#else
> +	   if (platformDisplay.eglCheckVersion(1, 4)) {
> +#endif

How about:

} else
#endif
    if (platformDisplay.eglCheckVersion(1, 4)) {

That way we don't need to repeat the condition at all.