[webkit-reviews] review granted: [Bug 197998] Add extra information to dumpJITMemory : [Attachment 370151] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 197998: Add extra information to dumpJITMemory
https://bugs.webkit.org/show_bug.cgi?id=197998

Attachment 370151: Patch

https://bugs.webkit.org/attachment.cgi?id=370151&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 370151
  --> https://bugs.webkit.org/attachment.cgi?id=370151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370151&action=review

r=me with one nit. Going to cq+ for now so this lands, feel free to just commit
the followup

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:568
> +	   ASSERT(dumpJITMemoryLock.isLocked());

Maybe also assert this in enqueue flush? Alternatively, take locker as
parameter

> Source/JavaScriptCore/jit/ExecutableAllocator.cpp:596
> +	  
flushQueue.get()->dispatchAfter(Seconds(Options::dumpJITMemoryFlushInterval()),
[] {

nit: doesn’t Ref’s operator -> handle this? I don’t think you need the get()

> Source/JavaScriptCore/runtime/Options.h:521
> +    v(double, dumpJITMemoryFlushInterval, 10, Restricted, nullptr) \

Nit: I’d include the interval in the name or at least in the description of the
option.