[webkit-reviews] review granted: [Bug 178319] Change String::number to not implicitly be "fixed precision 6 digits" : [Attachment 369918] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 178319: Change String::number to not implicitly be "fixed precision 6
digits"
https://bugs.webkit.org/show_bug.cgi?id=178319

Attachment 369918: Patch

https://bugs.webkit.org/attachment.cgi?id=369918&action=review




--- Comment #29 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 369918
  --> https://bugs.webkit.org/attachment.cgi?id=369918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369918&action=review

> Source/WTF/wtf/text/StringBuilder.h:236
>      // FIXME: Delete in favor of the name appendShortestFormNumber or just
appendNumber.

Since appendNumber for these types are now 'delete', this comment should be
updated to just call for using appendShortestFormNumber.

> Source/WTF/wtf/text/WTFString.h:193
>      // FIXME: Delete in favor of the name numberToStringShortest or just
number.

Since number for these types are now 'delete', this comment should be updated
to just call for using numberToStringShortest.