[webkit-reviews] review granted: [Bug 196307] [ Mac WK2 iOS Sim] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure : [Attachment 369559] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 17 16:10:29 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 196307: [ Mac WK2 iOS Sim] Layout Test
http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-wi
th-link-decoration.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196307
Attachment 369559: Patch
https://bugs.webkit.org/attachment.cgi?id=369559&action=review
--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 369559
--> https://bugs.webkit.org/attachment.cgi?id=369559
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=369559&action=review
>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:618
> + m_dumpResourceLoadStatisticsFunction = WTFMove(completionHandler);
Let's call this m_dumpResourceLoadStatisticsCompletionHandler, and assert that
it's null before this sets it.
More information about the webkit-reviews
mailing list