[webkit-reviews] review granted: [Bug 197934] [CMake] Use builtin FindICU : [Attachment 370152] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 197934: [CMake] Use builtin FindICU
https://bugs.webkit.org/show_bug.cgi?id=197934

Attachment 370152: Patch

https://bugs.webkit.org/attachment.cgi?id=370152&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370152
  --> https://bugs.webkit.org/attachment.cgi?id=370152
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370152&action=review

This is beginning to look a lot like a better future.

More targets, please!

> Source/cmake/target/icu.cmake:2
> +# Apple ports provide their own ICU that can't be found by
find_package(ICU).
> +# This file will create targets that would be created by find_package(ICU).

Well, we removed a find module and grew... basically another find module?
Anyway, it's fine.