[webkit-reviews] review granted: [Bug 197996] [ews-build] Add clickable url in UI for uploaded S3 archive : [Attachment 370148] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 17 14:12:06 PDT 2019


Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 197996: [ews-build] Add clickable url in UI for uploaded S3 archive
https://bugs.webkit.org/show_bug.cgi?id=197996

Attachment 370148: Patch

https://bugs.webkit.org/attachment.cgi?id=370148&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 370148
  --> https://bugs.webkit.org/attachment.cgi?id=370148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370148&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:800
> +	   match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text)

Can we have a comment here with an example of the line we're mapping?


More information about the webkit-reviews mailing list