[webkit-reviews] review granted: [Bug 197995] Avoid races in taking networking assertions for downloads by having both Networking and UIProcess do it : [Attachment 370140] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 197995: Avoid races in taking networking assertions for downloads by having
both Networking and UIProcess do it
https://bugs.webkit.org/show_bug.cgi?id=197995

Attachment 370140: Patch

https://bugs.webkit.org/attachment.cgi?id=370140&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 370140
  --> https://bugs.webkit.org/attachment.cgi?id=370140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370140&action=review

> Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:64
> +	   RELEASE_LOG(Loading, "Took 'WebKit downloads' assertion in
NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/NetworkProcess/Downloads/DownloadMap.cpp:78
> +	   RELEASE_LOG(Loading, "Dropped 'WebKit downloads' assertion in
NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:97
> +	   RELEASE_LOG(Loading, "UIProcess took 'WebKit downloads' assertions
for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:125
> +	   RELEASE_LOG(Loading, "UIProcess released 'WebKit downloads'
assertions for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.

> Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:141
> +    RELEASE_LOG(Loading, "UIProcess DownloadProxyMap invalidated - Released
'WebKit downloads' assertions for UIProcess and NetworkProcess");

We normally use ProcessSuspension channel for such logging.