[webkit-reviews] review granted: [Bug 197955] Web Inspector: Dark Mode: Fix colors in network table waterfall container : [Attachment 370139] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 17 13:33:56 PDT 2019
Devin Rousso <drousso at apple.com> has granted Jamal Nasser <jamaln at mail.com>'s
request for review:
Bug 197955: Web Inspector: Dark Mode: Fix colors in network table waterfall
container
https://bugs.webkit.org/show_bug.cgi?id=197955
Attachment 370139: Patch
https://bugs.webkit.org/attachment.cgi?id=370139&action=review
--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 370139
--> https://bugs.webkit.org/attachment.cgi?id=370139
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=370139&action=review
r=me, nice fix!
> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:211
> + background-color: var(--network-waterfall-fullscreen-area-color);
There's no reason to make a variable if it's only really used once (or even
twice). Please just inline it.
More information about the webkit-reviews
mailing list