[webkit-reviews] review granted: [Bug 197950] [iOS] Select all with existing range selection replaces range instead of selecting all text : [Attachment 370048] Patch and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 17 11:06:17 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 197950: [iOS] Select all with existing range selection replaces range
instead of selecting all text
https://bugs.webkit.org/show_bug.cgi?id=197950

Attachment 370048: Patch and layout test

https://bugs.webkit.org/attachment.cgi?id=370048&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 370048
  --> https://bugs.webkit.org/attachment.cgi?id=370048
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=370048&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3000
> +	   return !editorState.selectionIsNone && self.hasContent;

This might also mean that the callout bar when there's a ranged selection will
now contain "Select All", but I don't think that is necessarily a bad thing :)


More information about the webkit-reviews mailing list