[webkit-reviews] review granted: [Bug 165603] Implement CSS `display: flow-root` (modern clearfix) : [Attachment 369909] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 19:27:53 PDT 2019

zalan <zalan at apple.com> has granted Joonghun Park <jh718.park at samsung.com>'s
request for review:
Bug 165603: Implement CSS `display: flow-root` (modern clearfix)

Attachment 369909: Patch


--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 369909
  --> https://bugs.webkit.org/attachment.cgi?id=369909

Unfortunately we can't explicitly say that this block level box should
establish a block formatting context, instead the combination of the renderer
type (RenderBlock in this case) and its children will imply the type of layout
(e.g. inline vs block). ::createsNewFormattingContext() is really mostly used
to check against float intruding and avoiding. So while this patch is fine in
this context, we really lack some fundamental CSS basics in our codebase.

More information about the webkit-reviews mailing list