[webkit-reviews] review granted: [Bug 165603] Implement CSS `display: flow-root` (modern clearfix) : [Attachment 369909] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Joonghun Park <jh718.park at samsung.com>'s
request for review:
Bug 165603: Implement CSS `display: flow-root` (modern clearfix)
https://bugs.webkit.org/show_bug.cgi?id=165603

Attachment 369909: Patch

https://bugs.webkit.org/attachment.cgi?id=369909&action=review




--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 369909
  --> https://bugs.webkit.org/attachment.cgi?id=369909
Patch

Unfortunately we can't explicitly say that this block level box should
establish a block formatting context, instead the combination of the renderer
type (RenderBlock in this case) and its children will imply the type of layout
(e.g. inline vs block). ::createsNewFormattingContext() is really mostly used
to check against float intruding and avoiding. So while this patch is fine in
this context, we really lack some fundamental CSS basics in our codebase.