[webkit-reviews] review granted: [Bug 197959] Allow sequential playback of media files when initial playback started with a user gesture : [Attachment 370061] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 14:29:42 PDT 2019


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 197959: Allow sequential playback of media files when initial playback
started with a user gesture
https://bugs.webkit.org/show_bug.cgi?id=197959

Attachment 370061: Patch

https://bugs.webkit.org/attachment.cgi?id=370061&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 370061
  --> https://bugs.webkit.org/attachment.cgi?id=370061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370061&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5921
> +	   document().mediaFinishedPlaying();

Maybe we should have a better name for mediaFinishedPlaying, since it is not
called for every media but only 'unrestricted' media.


More information about the webkit-reviews mailing list