[webkit-reviews] review granted: [Bug 192950] Implement imagesrcset and imagesizes attributes on link rel=preload : [Attachment 369976] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 192950: Implement imagesrcset and imagesizes attributes on link rel=preload
https://bugs.webkit.org/show_bug.cgi?id=192950

Attachment 369976: Patch

https://bugs.webkit.org/attachment.cgi?id=369976&action=review




--- Comment #31 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 369976
  --> https://bugs.webkit.org/attachment.cgi?id=369976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369976&action=review

> Source/WebCore/loader/LinkLoader.cpp:250
> +	   url = href;

s/url = href/url = document.completeURL(href)/

> Source/WebCore/loader/LinkLoader.cpp:253
> +	   document.addConsoleMessage(MessageSource::Other,
MessageLevel::Error, "<link rel=preload> has an invalid `href` value"_s);

This is a bit misleading since we are talking in the message of href, while it
might be related to imageSrcSet value.
Can we improve on this, either by adding the URL that is invalid or by making
the message more specific.

> Source/WebCore/loader/LinkLoader.cpp:262
> +    auto linkRequest =
createPotentialAccessControlRequest(document.completeURL(url), document,
crossOriginMode, WTFMove(options));

s/document.completeURL(url)/url

> LayoutTests/ChangeLog:11
> +	   *
platform/ios-simulator-12-wk2/imported/w3c/web-platform-tests/preload/link-head
er-preload-imagesrcset-expected.txt: Added.

It should probably be ios-simulator-wk2 instead of ios-simulator-12-wk2.
Is there a way to modify the test to handle various dimensions?