[webkit-reviews] review granted: [Bug 197463] Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests : [Attachment 369902] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 197463: Reuse existing WebPageProxy quota handler for NetworkProcessProxy
quota requests
https://bugs.webkit.org/show_bug.cgi?id=197463

Attachment 369902: Patch

https://bugs.webkit.org/attachment.cgi?id=369902&action=review




--- Comment #20 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 369902
  --> https://bugs.webkit.org/attachment.cgi?id=369902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369902&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:297
> +    bool m_areBeingProcessing { false };

m_isProcessing or m_requestsAreBeingProcessed

> Source/WebKit/UIProcess/WebPageProxy.cpp:7262
> +	       StorageRequests::singleton().processNextIfAny();

I think it would be a better abstraction if the StorageRequests made its own
lambda that called this.

> Source/WebKit/UIProcess/WebProcessProxy.cpp:125
> +void WebProcessProxy::forWebPages(PAL::SessionID sessionID, const
SecurityOriginData& origin, const Function<void(WebPageProxy&)>& callback)

forWebPagesWithOrigin