[webkit-reviews] review denied: [Bug 197898] Only cache bytecode for API clients in data vaults : [Attachment 369910] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 197898: Only cache bytecode for API clients in data vaults
https://bugs.webkit.org/show_bug.cgi?id=197898

Attachment 369910: Patch

https://bugs.webkit.org/attachment.cgi?id=369910&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 369910
  --> https://bugs.webkit.org/attachment.cgi?id=369910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369910&action=review

> Source/JavaScriptCore/API/JSScript.mm:87
> +#if USE(APPLE_INTERNAL_SDK)

I don't like this. We should mock this API for non-apple internal builds. Those
functions should still be linked against.

> Source/JavaScriptCore/API/JSScript.mm:88
> +    if
(rootless_check_datavault_flag(FileSystem::fileSystemRepresentation(directory).
data(), nullptr)) {

What does this do on iOS?