[webkit-reviews] review granted: [Bug 197862] Missing cursor/caret showing in search field on google.com : [Attachment 369857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 15:54:22 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 197862: Missing cursor/caret showing in search field on google.com
https://bugs.webkit.org/show_bug.cgi?id=197862

Attachment 369857: Patch

https://bugs.webkit.org/attachment.cgi?id=369857&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 369857
  --> https://bugs.webkit.org/attachment.cgi?id=369857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369857&action=review

> Source/WebCore/rendering/RenderLayer.cpp:6812
> +	   layer->calculateRects({ renderViewLayer, TemporaryClipRects },
LayoutRect::infiniteRect(), layerBounds, backgroundRect, foregroundRect,
layer->offsetFromAncestor(renderViewLayer));

I think this is the same as AbsoluteClipRects.

I think you can just do:

auto rect = layer.backgroundClipRect(RenderLayer::ClipRectsContext(rootLayer,
AbsoluteClipRects)).rect().

Ideally factor this out into a lambda so it's clear you're hopping up a frame
in each loop iteration.


More information about the webkit-reviews mailing list