[webkit-reviews] review granted: [Bug 197856] Add assertions to help diagnose crash at WebProcessProxy::processPool() : [Attachment 369890] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 197856: Add assertions to help diagnose crash at
WebProcessProxy::processPool()
https://bugs.webkit.org/show_bug.cgi?id=197856

Attachment 369890: Patch

https://bugs.webkit.org/attachment.cgi?id=369890&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 369890
  --> https://bugs.webkit.org/attachment.cgi?id=369890
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369890&action=review

> Source/WebKit/UIProcess/WebProcessCache.cpp:250
> +   
RELEASE_ASSERT(!m_process->websiteDataStore().hasProcess(process.ptr()));

RELEASE_ASSERT_WITH_MESSAGE(!m_process->websiteDataStore().hasProcess(process.p
tr()), "Only processes with pages should be registered with the data store");