[webkit-reviews] review granted: [Bug 197476] Hide MediaCapabilities.encodingInfo() when the platform does not support it. : [Attachment 369798] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 197476: Hide MediaCapabilities.encodingInfo() when the platform does not
support it.
https://bugs.webkit.org/show_bug.cgi?id=197476

Attachment 369798: Patch

https://bugs.webkit.org/attachment.cgi?id=369798&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 369798
  --> https://bugs.webkit.org/attachment.cgi?id=369798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369798&action=review

> LayoutTests/ChangeLog:13
> +	   *
platform/ios/media/mediacapabilities/mediacapabilities-encodingInfo-undefined-e
xpected.txt: Added.
> +	   *
platform/ios/media/mediacapabilities/mediacapabilities-encodingInfo-undefined.h
tml: Added.
> +	   *
platform/ios/media/mediacapabilities/mediacapabilities-types-expected.txt:
Added.
> +	   *
platform/mac/media/mediacapabilities/mediacapabilities-encodingInfo-undefined-e
xpected.txt: Added.
> +	   *
platform/mac/media/mediacapabilities/mediacapabilities-encodingInfo-undefined.h
tml: Added.
> +	   *
platform/mac/media/mediacapabilities/mediacapabilities-types-expected.txt:
Added.

Do we really need to add duplicate tests and results, couldn't you add one copy
of each in media/mediacapabilities/ and skip the tests on platforms where they
aren't supported (yet)?