[webkit-reviews] review granted: [Bug 197854] [css-grid] Use max size to compute auto repeat tracks : [Attachment 369790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 02:10:43 PDT 2019

Javier Fernandez <jfernandez at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 197854: [css-grid] Use max size to compute auto repeat tracks

Attachment 369790: Patch


--- Comment #8 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 369790
  --> https://bugs.webkit.org/attachment.cgi?id=369790

View in context: https://bugs.webkit.org/attachment.cgi?id=369790&action=review

> Source/WebCore/rendering/RenderGrid.cpp:463
> +	   LayoutUnit availableMaxSize = LayoutUnit();

I don't think we need to initialize to LayoutUnit()

> Source/WebCore/rendering/RenderGrid.cpp:472
> +	   if (!availableMaxSize && !minSize.isSpecified())

I think the use of ! here is confusing (it may imply the availableMaxSize is an
optional value) Wouldn't be better (clearer) to use > 0 instead ?

> Source/WebCore/rendering/RenderGrid.cpp:475
> +	   LayoutUnit availableMinSize = LayoutUnit();


More information about the webkit-reviews mailing list