[webkit-reviews] review requested: [Bug 185626] A service worker process should app nap when all its clients app nap : [Attachment 369599] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 185626: A service worker process should app nap when all its clients app
nap
https://bugs.webkit.org/show_bug.cgi?id=185626

Attachment 369599: Patch

https://bugs.webkit.org/attachment.cgi?id=369599&action=review




--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 369599
  --> https://bugs.webkit.org/attachment.cgi?id=369599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369599&action=review

> Source/WebCore/workers/service/SWClientConnection.h:89
> +    virtual void updateThrottleState() = 0;

I don't think this needs to be public. Can probably be protected.

> Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:283
> +    if (!m_isThrottleable)

You're registering a new client, how come this cannot get us out of
throttleable state?