[webkit-reviews] review granted: [Bug 197384] [CG] Add support for HEIF-sequence (‘public.heics’) images : [Attachment 369556] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 197384: [CG] Add support for HEIF-sequence (‘public.heics’) images
https://bugs.webkit.org/show_bug.cgi?id=197384

Attachment 369556: Patch

https://bugs.webkit.org/attachment.cgi?id=369556&action=review




--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 369556
  --> https://bugs.webkit.org/attachment.cgi?id=369556
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369556&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:340
> +    if (properties)
> +	   frameProperties =
(CFDictionaryRef)CFDictionaryGetValue(properties.get(),
kCGImagePropertyGIFDictionary);
> +    
> +    if (properties && !frameProperties)
> +	   frameProperties =
(CFDictionaryRef)CFDictionaryGetValue(properties.get(),
kCGImagePropertyPNGDictionary);
> +

This looks like the code above. Maybe share into a small static function.