[webkit-reviews] review granted: [Bug 197790] Bugzilla should convert "r12345" to a trac.webkit.org link : [Attachment 369575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 12 14:53:33 PDT 2019

Alexey Proskuryakov <ap at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 197790: Bugzilla should convert "r12345" to a trac.webkit.org link

Attachment 369575: Patch


--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 369575
  --> https://bugs.webkit.org/attachment.cgi?id=369575

View in context: https://bugs.webkit.org/attachment.cgi?id=369575&action=review

I guess this should work in the overwhelming majority of cases.

> Websites/bugs.webkit.org/extensions/Trac/Extension.pm:32
> +use Bugzilla::Constants;
> +use Bugzilla::Group;
> +use Bugzilla::User;

Which of these are actually used?

> Websites/bugs.webkit.org/extensions/Trac/Extension.pm:38
> +    my ($self, $args) = @_;
> +	   my $regexes = $args->{'regexes'};

Too much indentation.

> Websites/bugs.webkit.org/extensions/Trac/Extension.pm:49
> +    return qq{<a href="//trac.webkit.org/$revision">$text</a>};

Why not say "https:"? These are separate servers, and while both are https
only, there is no strict coupling.

More information about the webkit-reviews mailing list