[webkit-reviews] review granted: [Bug 197798] Take out MediaPlayback UI assertion when any WebProcess is playing audible media : [Attachment 369612] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 16:34:15 PDT 2019


Chris Dumez <cdumez at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 197798: Take out MediaPlayback UI assertion when any WebProcess is playing
audible media
https://bugs.webkit.org/show_bug.cgi?id=197798

Attachment 369612: Patch

https://bugs.webkit.org/attachment.cgi?id=369612&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 369612
  --> https://bugs.webkit.org/attachment.cgi?id=369612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369612&action=review

r=me

> Source/WebKit/UIProcess/WebProcessPool.cpp:2587
> +    auto result = m_processesPlayingAudibleMedia.add(processID, nullptr);

Could you
ASSERT(!m_processesPlayingAudibleMedia.contains(process.coreProcessIdentifier()
)) in WebProcessPool::disconnectProcess() ? Just to be safe :) Maybe even
RELEASE_ASSERT() since so don't often run debug on iOS.


More information about the webkit-reviews mailing list