[webkit-reviews] review granted: [Bug 197750] Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted : [Attachment 369517] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 197750: Do not wait until requestPermission() is called to fire
deviceorientation events if permission was already granted
https://bugs.webkit.org/show_bug.cgi?id=197750

Attachment 369517: Patch

https://bugs.webkit.org/attachment.cgi?id=369517&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 369517
  --> https://bugs.webkit.org/attachment.cgi?id=369517
Patch

r=me

I do remember the discussion around caching the Granted state for the current
session, and I think that makes sense. (The privacy problem only really happens
when permission is implicitly granted across websites, which doesn't happen in
this case.)

I don't specifically remember a discussion around caching the Denied state. I
wonder if that's the right choice. I do worry that a user could deny -- by
accident or on purpose -- and then not know how to change that decision.