[webkit-reviews] review granted: [Bug 197777] Add WKWebViewConfiguration._canShowWhileLocked SPI : [Attachment 369555] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 09:45:49 PDT 2019


Tim Horton <thorton at apple.com> has granted  review:
Bug 197777: Add WKWebViewConfiguration._canShowWhileLocked SPI
https://bugs.webkit.org/show_bug.cgi?id=197777

Attachment 369555: Patch

https://bugs.webkit.org/attachment.cgi?id=369555&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 369555
  --> https://bugs.webkit.org/attachment.cgi?id=369555
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369555&action=review

> Source/WebKit/Platform/mac/LayerHostingContext.mm:62
> +	   kCAContextSecure: canShowWhileLocked ? @YES : @NO,

@(canShowWhileLocked)

> Source/WebKit/Platform/mac/LayerHostingContext.mm:71
> +	   kCAContextCIFilterBehavior :  @"ignore",

Pretty sure these are all Mac paths and don’t support this option. But maybe
the symbol is there and the extra key will be ignored?


More information about the webkit-reviews mailing list