[webkit-reviews] review granted: [Bug 197694] Event region generation needs to know about backing-sharing : [Attachment 369548] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 08:48:16 PDT 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 197694: Event region generation needs to know about backing-sharing

Attachment 369548: patch


--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 369548
  --> https://bugs.webkit.org/attachment.cgi?id=369548

View in context: https://bugs.webkit.org/attachment.cgi?id=369548&action=review

>> Source/WebCore/rendering/RenderLayerBacking.cpp:1497
>> +	    layerWeakPtr->paintLayerContents(nullContext, paintingInfo,
> Do you need to null check layerWeakPtr here?

No, we think that's a correctness bug and are OK with a null-deref crash.

However, this code will be wrong when the sharing layers have transforms.
Please file a follow-up bug to fix that. You'll need to use something like I'm
adding in bug 197692.

More information about the webkit-reviews mailing list