[webkit-reviews] review granted: [Bug 197270] [WPE][GTK] Add webkit_frame_get_id() API : [Attachment 368435] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 10 02:40:54 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 197270: [WPE][GTK] Add webkit_frame_get_id() API
https://bugs.webkit.org/show_bug.cgi?id=197270

Attachment 368435: Patch

https://bugs.webkit.org/attachment.cgi?id=368435&action=review




--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 368435
  --> https://bugs.webkit.org/attachment.cgi?id=368435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368435&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:74
> +{

g_return_val_if_fail(WEBKIT_IS_FRAME(fraem), 0);

> Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:167
> +	   GRefPtr<JSCValue> undefined =
adoptGRef(jsc_value_object_invoke_method(contentWindow.get(), "postMessage",
G_TYPE_STRING, "submit the form!", G_TYPE_STRING, "*", G_TYPE_NONE));
> +	   g_assert_true(JSC_IS_VALUE(undefined.get()));
> +	   g_assert_true(jsc_value_is_undefined(undefined.get()));

Why don't you call submit() directly on the form here? Maybe you don't even
need to run loop, just connect the signal before

>
Tools/TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:5
> +    <file
alias="form-in-frame.html">Tools/TestWebKitAPI/Tests/WebKitGLib/resources/form-
in-frame.html</file>

Dos this need to be a resource?


More information about the webkit-reviews mailing list