[webkit-reviews] review denied: [Bug 197650] [Curl] Suppress extra didReceiveAuthenticationChallenge call when accessing a server which checks basic auth. : [Attachment 369540] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 197650: [Curl] Suppress extra didReceiveAuthenticationChallenge call when
accessing a server which checks basic auth.
https://bugs.webkit.org/show_bug.cgi?id=197650

Attachment 369540: Patch

https://bugs.webkit.org/attachment.cgi?id=369540&action=review




--- Comment #24 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369540
  --> https://bugs.webkit.org/attachment.cgi?id=369540
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369540&action=review

> LayoutTests/TestExpectations:451
> +http/tests/misc/certificate-and-authentication.html [ Skip ]

This test is skipped not only becasue it is only work in WebKit2, but also
because it is only for curl port.
Let's rename to http/tests/ssl/curl/certificate-and-authentication.html,
and skip the directory.
http/tests/ssl/curl [ Skip ]

> LayoutTests/http/tests/misc/certificate-and-authentication.html:32
> +    const iframe = await
with_iframe("https://localhost:8443/xmlhttprequest/resources/basic-auth/basic-a
uth.php?uid=user");

See Basuke's Comment 20. You should move the script into the
http/tests/resources or copy the script.