[webkit-reviews] review canceled: [Bug 196289] [WinCairo] storage/indexeddb tests are timing out : [Attachment 369457] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 196289: [WinCairo] storage/indexeddb tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=196289

Attachment 369457: Patch

https://bugs.webkit.org/attachment.cgi?id=369457&action=review




--- Comment #36 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369457
  --> https://bugs.webkit.org/attachment.cgi?id=369457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369457&action=review

>> Source/WTF/wtf/glib/FileSystemGlib.cpp:456
>> +	return !!::CopyFile(source.charactersWithNullTermination().data(),
destination.charactersWithNullTermination().data(), TRUE);
> 
> Why do we use charactersWithNullTermination here...

Good catch. It should be wideCharacters. We should use wideCharacters for Win32
API after ICU 59.