[webkit-reviews] review canceled: [Bug 196289] [WinCairo] storage/indexeddb tests are timing out : [Attachment 369457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 19:04:13 PDT 2019

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 196289: [WinCairo] storage/indexeddb tests are timing out

Attachment 369457: Patch


--- Comment #36 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369457
  --> https://bugs.webkit.org/attachment.cgi?id=369457

View in context: https://bugs.webkit.org/attachment.cgi?id=369457&action=review

>> Source/WTF/wtf/glib/FileSystemGlib.cpp:456
>> +	return !!::CopyFile(source.charactersWithNullTermination().data(),
destination.charactersWithNullTermination().data(), TRUE);
> Why do we use charactersWithNullTermination here...

Good catch. It should be wideCharacters. We should use wideCharacters for Win32
API after ICU 59.

More information about the webkit-reviews mailing list