[webkit-reviews] review granted: [Bug 197758] Returning incorrect marked text rects : [Attachment 369529] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 9 17:41:08 PDT 2019
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 197758: Returning incorrect marked text rects
https://bugs.webkit.org/show_bug.cgi?id=197758
Attachment 369529: Patch
https://bugs.webkit.org/attachment.cgi?id=369529&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 369529
--> https://bugs.webkit.org/attachment.cgi?id=369529
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=369529&action=review
> Source/WebKit/ChangeLog:9
> + We are not returning marked text rects in the correct view
coordinant space.
coordinate
> Source/WebKit/ChangeLog:13
> + (WebKit::WebPage::platformEditorState const):
Where's the test :P
More information about the webkit-reviews
mailing list