[webkit-reviews] review granted: [Bug 193876] [iOS] Right command key has wrong value for property code : [Attachment 369523] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 193876: [iOS] Right command key has wrong value for property code
https://bugs.webkit.org/show_bug.cgi?id=193876

Attachment 369523: Patch

https://bugs.webkit.org/attachment.cgi?id=369523&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 369523
  --> https://bugs.webkit.org/attachment.cgi?id=369523
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369523&action=review

r=me

> Source/WebCore/ChangeLog:11
> +	   the correct value for the code property of the DOM key event.

Do we still need RWIN if the user is running a Microsoft keyboard?

> Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:278
> +    case VK_APPS: return "MetaRight"_s;

I wonder if we should just keep both of them?