[webkit-reviews] review granted: [Bug 197740] REGRESSION (r245064): ASSERTION FAILED: m_ptr seen with wasm.yaml/wasm/js-api/test_Data.js.wasm-slow-memory : [Attachment 369496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 10:39:58 PDT 2019


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 197740: REGRESSION (r245064): ASSERTION FAILED: m_ptr seen with
wasm.yaml/wasm/js-api/test_Data.js.wasm-slow-memory
https://bugs.webkit.org/show_bug.cgi?id=197740

Attachment 369496: Patch

https://bugs.webkit.org/attachment.cgi?id=369496&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 369496
  --> https://bugs.webkit.org/attachment.cgi?id=369496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369496&action=review

> Source/JavaScriptCore/runtime/JSArrayBufferView.h:138
> +	   void* vector() const { return m_vector.getMayBeNull(m_length); }

Worth saying why this can be null now in changelog


More information about the webkit-reviews mailing list