[webkit-reviews] review granted: [Bug 197738] pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a timeout : [Attachment 369490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 9 07:10:47 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 197738:
pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html is a
timeout
https://bugs.webkit.org/show_bug.cgi?id=197738

Attachment 369490: Patch

https://bugs.webkit.org/attachment.cgi?id=369490&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 369490
  --> https://bugs.webkit.org/attachment.cgi?id=369490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369490&action=review

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.mm:345
> +	   m_activeTouchActions =
scrollingCoordinatorProxy.activeTouchActionsForTouchIdentifier(*touchIdentifier
);

Should this be cleared when the scrolling fully finishes? Seem bet weird that
it can stay non-empty long past the gesture.


More information about the webkit-reviews mailing list