[webkit-reviews] review granted: [Bug 197724] [Legacy WebKit] REGRESSION (r238078): Crash in hardwareKeyboardAvailabilityChangedCallback() : [Attachment 369444] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 197724: [Legacy WebKit] REGRESSION (r238078): Crash in
hardwareKeyboardAvailabilityChangedCallback()
https://bugs.webkit.org/show_bug.cgi?id=197724

Attachment 369444: Patch

https://bugs.webkit.org/attachment.cgi?id=369444&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 369444
  --> https://bugs.webkit.org/attachment.cgi?id=369444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369444&action=review

> Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:824
> +    auto weakWebView = WeakObjCPtr<WebHTMLView>((__bridge WebHTMLView
*)observer);

You can probably just __weak, but this is fine too