[webkit-reviews] review granted: [Bug 197710] Pass insertTextAsync options as a struct : [Attachment 369431] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 15:25:30 PDT 2019

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 197710: Pass insertTextAsync options as a struct

Attachment 369431: Patch


--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 369431
  --> https://bugs.webkit.org/attachment.cgi?id=369431

View in context: https://bugs.webkit.org/attachment.cgi?id=369431&action=review

Looks like a nice simplification. r=me.

> Source/WebKit/Shared/Cocoa/InsertTextOptions.h:36
> +    EditingRangeIsRelativeTo editingRangeIsRelativeTo {
EditingRangeIsRelativeTo::EditableRoot };

It might be more space-efficient to move the booleans to the bottom of the

More information about the webkit-reviews mailing list