[webkit-reviews] review granted: [Bug 197686] iOS: Selection is dismissed even if click is preventDefault()'d : [Attachment 369397] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 11:33:34 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 197686: iOS: Selection is dismissed even if click is preventDefault()'d
https://bugs.webkit.org/show_bug.cgi?id=197686

Attachment 369397: Patch

https://bugs.webkit.org/attachment.cgi?id=369397&action=review




--- Comment #11 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 369397
  --> https://bugs.webkit.org/attachment.cgi?id=369397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369397&action=review

>
LayoutTests/editing/selection/ios/persist-selection-after-tapping-on-element-wi
th-click-handler-expected.txt:3
> +This test verifies that the WebCore selection is not dismissed when tapping
on an element that preventDefault()s the click event.

Nit - perhaps s/WebCore/DOM/?


More information about the webkit-reviews mailing list