[webkit-reviews] review granted: [Bug 197666] Regression: Crash at WebKit: PAL::HysteresisActivity::start : [Attachment 369349] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 197666: Regression: Crash at WebKit: PAL::HysteresisActivity::start
https://bugs.webkit.org/show_bug.cgi?id=197666

Attachment 369349: Patch

https://bugs.webkit.org/attachment.cgi?id=369349&action=review




--- Comment #11 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 369349
  --> https://bugs.webkit.org/attachment.cgi?id=369349
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369349&action=review

r=me

> Source/WebKit/ChangeLog:18
> +	   1. The constructor takes in a WTF::Function instead of a
NetworkProcess / WebProcess crash. This is provides

crash => reference

> Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp:52
> +	   notifyClient(false);

I'd say

    bool isHoldingLockedFiles = false;
    notifyClient(isHoldingLockedFiles);

to avoid a cryptic boolean argument.

(I prefer this style to adding a comment about the meaning of the boolean
argument. Code speaks. Comments mumble.)