[webkit-reviews] review granted: [Bug 197690] [GTK] Support navigation gesture on touchscreens : [Attachment 369370] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Alexander Mikhaylenko
<exalm7659 at gmail.com>'s request for review:
Bug 197690: [GTK] Support navigation gesture on touchscreens
https://bugs.webkit.org/show_bug.cgi?id=197690

Attachment 369370: Patch

https://bugs.webkit.org/attachment.cgi?id=369370&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 369370
  --> https://bugs.webkit.org/attachment.cgi?id=369370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369370&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:40
> +static const double gtkScrollDeltaMultiplier = 10;

A lot of users have been complaining that scrolling the web view doesn't move
the web content as much as in other browsers. Is that something you'd be
interested in trying to improve?

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:190
> +    if (isTouchEvent(event))
> +	   deltaX *= (double) Scrollbar::pixelsPerLineStep() /
m_webPageProxy.viewSize().width();
> +    else
> +	   deltaX *= gtkScrollDeltaMultiplier / swipeTouchpadBaseWidth;

Just make sure the divisors can never be zero.