[webkit-reviews] review granted: [Bug 197690] [GTK] Support navigation gesture on touchscreens : [Attachment 369370] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 08:25:31 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Alexander Mikhaylenko
<exalm7659 at gmail.com>'s request for review:
Bug 197690: [GTK] Support navigation gesture on touchscreens

Attachment 369370: Patch


--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 369370
  --> https://bugs.webkit.org/attachment.cgi?id=369370

View in context: https://bugs.webkit.org/attachment.cgi?id=369370&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:40
> +static const double gtkScrollDeltaMultiplier = 10;

A lot of users have been complaining that scrolling the web view doesn't move
the web content as much as in other browsers. Is that something you'd be
interested in trying to improve?

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:190
> +    if (isTouchEvent(event))
> +	   deltaX *= (double) Scrollbar::pixelsPerLineStep() /
> +    else
> +	   deltaX *= gtkScrollDeltaMultiplier / swipeTouchpadBaseWidth;

Just make sure the divisors can never be zero.

More information about the webkit-reviews mailing list