[webkit-reviews] review granted: [Bug 197561] Implement "shared" compositing layers, allowing overlap layers to paint into the backing store of another layer : [Attachment 369357] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 8 00:16:55 PDT 2019


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 197561: Implement "shared" compositing layers, allowing overlap layers to
paint into the backing store of another layer
https://bugs.webkit.org/show_bug.cgi?id=197561

Attachment 369357: Patch

https://bugs.webkit.org/attachment.cgi?id=369357&action=review




--- Comment #44 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 369357
  --> https://bugs.webkit.org/attachment.cgi?id=369357
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369357&action=review

Looks fine. Fixing updateEventRegion shouldn't be difficult either (same thing
as paintIntoLayer) but it can be done separately if you prefer.

> Source/WebCore/rendering/RenderLayer.cpp:1774
> +//	 ASSERT_IMPLIES(backingProvider, !isComposited());

Commented-out code.

> Source/WebCore/rendering/RenderLayerBacking.cpp:679
> +	   if (!layerWeakPtr) {
> +	       ASSERT_NOT_REACHED();
> +	       continue;
> +	   }

This seems overly defensive. We should just crash with nullptr if the logic is
supposed to guarantee that these are non-null (here and elsewhere).


More information about the webkit-reviews mailing list