[webkit-reviews] review canceled: [Bug 196289] [WinCairo] storage/indexeddb tests are timing out : [Attachment 369273] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 196289: [WinCairo] storage/indexeddb tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=196289

Attachment 369273: Patch

https://bugs.webkit.org/attachment.cgi?id=369273&action=review




--- Comment #29 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 369273
  --> https://bugs.webkit.org/attachment.cgi?id=369273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369273&action=review

>> Source/WTF/wtf/win/FileSystemWin.cpp:506
>>	return !!::CopyFile(source.wideCharacters().data(),
destination.wideCharacters().data(), TRUE);
> 
> Why not just implement hardLinkOrCopyFile like other platforms?

They are used for different usages.

hardLinkOrCopyFile is used only in
SQLiteIDBTransaction::moveBlobFilesIfNecessary. (Bug 156321)

https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/
Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp#L94

It is no problem for moveBlobFilesIfNecessary to use copying
becuase it will remove the source file soon.

On the other hand, BlobStorage::add should use hard linking
because BlobStorage unifies files which has the identical
content.

I don't know why moveBlobFilesIfNecessary needs the fallback of
using copy if hard linking fails. Is it possible to use only hard
linking even for moveBlobFilesIfNecessary case?