[webkit-reviews] review granted: [Bug 197674] Simplify logic to prevent App Nap in WebPage : [Attachment 369327] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 197674: Simplify logic to prevent App Nap in WebPage
https://bugs.webkit.org/show_bug.cgi?id=197674

Attachment 369327: Patch

https://bugs.webkit.org/attachment.cgi?id=369327&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 369327
  --> https://bugs.webkit.org/attachment.cgi?id=369327
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369327&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:768
> +    bool shouldAllowAppNapGivenPageState = m_isAppNapEnabled && !isActive &&
isVisuallyIdle;

Maybe call this isAppNapEnabledInThisPage. The if-then ("A given B") style of
naming threw me off a bit.