[webkit-reviews] review granted: [Bug 197397] Add SPI to set a list of hosts to which to send custom header fields cross-origin : [Attachment 369187] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 14:02:17 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 197397: Add SPI to set a list of hosts to which to send custom header
fields cross-origin
https://bugs.webkit.org/show_bug.cgi?id=197397

Attachment 369187: Patch

https://bugs.webkit.org/attachment.cgi?id=369187&action=review




--- Comment #22 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 369187
  --> https://bugs.webkit.org/attachment.cgi?id=369187
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369187&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.mm:52
> +    NSMutableDictionary<NSString *, NSString *> *dictionary =
[[[NSMutableDictionary alloc] initWithCapacity:vector.size()] autorelease];

You can use +dictionaryWithCapacity here.

> Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.mm:72
> +    NSMutableArray *array = [[[NSMutableArray alloc]
initWithCapacity:domains.size()] autorelease];

+arrayWithCapacity


More information about the webkit-reviews mailing list