[webkit-reviews] review granted: [Bug 195623] Link prefetch not useful for top-level navigation : [Attachment 368343] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 13:42:01 PDT 2019

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 195623: Link prefetch not useful for top-level navigation

Attachment 368343: Patch


--- Comment #179 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 368343
  --> https://bugs.webkit.org/attachment.cgi?id=368343

View in context: https://bugs.webkit.org/attachment.cgi?id=368343&action=review

> Source/WebKit/NetworkProcess/cache/PrefetchCache.h:50
> +	   Ref<WebCore::SharedBuffer> releaseBuffer() { return
buffer.releaseNonNull(); }

I do not think we can guarantee buffer will always be null.
We might just need to WTFMove(buffer) when storing it in network cache.

More information about the webkit-reviews mailing list