[webkit-reviews] review granted: [Bug 197265] [B3] Constants should be hoisted to the root block : [Attachment 369315] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 197265: [B3] Constants should be hoisted to the root block
https://bugs.webkit.org/show_bug.cgi?id=197265

Attachment 369315: Patch

https://bugs.webkit.org/attachment.cgi?id=369315&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 369315
  --> https://bugs.webkit.org/attachment.cgi?id=369315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369315&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   [B3] Constants should be hoisted to the root block

doesn't moveConstants undo this? (I'm not saying if that's good or bad, but
this title makes it seem like this wouldn't happen)

> Source/JavaScriptCore/ChangeLog:19
> +	   When I tried measuring the total effect on JetStream2 I got a tiny
and almost certainly non-significant progression.

Did you measure compile time effect?