[webkit-reviews] review granted: [Bug 197668] Add option to build-webkit to control whether or not XCBuild is used : [Attachment 369309] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 197668: Add option to build-webkit to control whether or not XCBuild is
used
https://bugs.webkit.org/show_bug.cgi?id=197668

Attachment 369309: Patch

https://bugs.webkit.org/attachment.cgi?id=369309&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 369309
  --> https://bugs.webkit.org/attachment.cgi?id=369309
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369309&action=review

> Tools/Scripts/build-webkit:76
> +my $xcbuild = -1;

undef is also an option

> Makefile.shared:48
> +	CAN_USE_XCBUILD = $(shell perl -I$(SCRIPTS_PATH) -Mwebkitdirs -e 'print
canUseXCBuild()')

😲