[webkit-reviews] review granted: [Bug 181169] Implement "line-break: anywhere" : [Attachment 368620] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 181169: Implement "line-break: anywhere"
https://bugs.webkit.org/show_bug.cgi?id=181169

Attachment 368620: Patch

https://bugs.webkit.org/attachment.cgi?id=368620&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 368620
  --> https://bugs.webkit.org/attachment.cgi?id=368620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368620&action=review

> Source/WebCore/rendering/BreakLines.h:194
> +    NonSharedCharacterBreakIterator iterator(stringView);

Is this really the correct type of iterator here?

There's likely a significant performance opportunity here, we should probably
file a new bug about using a shared iterator and add a FIXME here.

> Source/WebCore/rendering/BreakLines.h:206
> +    if (breakAnywhere) {
> +	   nextBreakable =
nextBreakablePositionBreakCharacter(lazyBreakIterator, startPosition);
> +    } else if (keepAllWords) {

Didn't the style checker catch the unnecessary { } ?

Do we need to have two variants for the NBSP behavior?