[webkit-reviews] review granted: [Bug 197622] Rewrite generate-xcfilelists in Python : [Attachment 369198] Address style issues. The remaining two are bogus.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 6 17:03:30 PDT 2019
Alex Christensen <achristensen at apple.com> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 197622: Rewrite generate-xcfilelists in Python
https://bugs.webkit.org/show_bug.cgi?id=197622
Attachment 369198: Address style issues. The remaining two are bogus.
https://bugs.webkit.org/attachment.cgi?id=369198&action=review
--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 369198
--> https://bugs.webkit.org/attachment.cgi?id=369198
Address style issues. The remaining two are bogus.
View in context: https://bugs.webkit.org/attachment.cgi?id=369198&action=review
Nothing jumps out to me as problematic. I definitely like that it's not bash.
It wouldn't hurt to have someone who works more on our python tools look it
over, but r=me
> Tools/ChangeLog:9
> + For a number of reasons, rewrite generate-xcfilelists in Python:
No perl?
> Tools/Scripts/webkitpy/generate_xcfilelists_lib/application.py:78
> + # ("", "iosmac"),
Why are these commented?
> Tools/Scripts/webkitpy/generate_xcfilelists_lib/util.py:261
> +# The algorithm is adopted from the following article:
adapted?
More information about the webkit-reviews
mailing list