[webkit-reviews] review granted: [Bug 197605] JS2 should print scores for different categories : [Attachment 369153] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 197605: JS2 should print scores for different categories
https://bugs.webkit.org/show_bug.cgi?id=197605

Attachment 369153: patch

https://bugs.webkit.org/attachment.cgi?id=369153&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 369153
  --> https://bugs.webkit.org/attachment.cgi?id=369153
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369153&action=review

r=me

> PerformanceTests/JetStream2/JetStreamDriver.js:53
> +    for (let [category, scores] of categoryScores)
> +	   summaryElement.innerHTML += `<p> ${category}:
${uiFriendlyNumber(geomean(scores))}</p>`

I think sorting the categories is better.

> PerformanceTests/JetStream2/JetStreamDriver.js:247
> +	       for (let [category, scores] of categoryScores)
> +		   console.log(`${category}:
${uiFriendlyNumber(geomean(scores))}`);

Ditto.