[webkit-reviews] review denied: [Bug 197384] [CG] Add support for HEIF-sequence (‘public.heics’) images : [Attachment 369128] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 197384: [CG] Add support for HEIF-sequence (‘public.heics’) images
https://bugs.webkit.org/show_bug.cgi?id=197384

Attachment 369128: Patch

https://bugs.webkit.org/attachment.cgi?id=369128&action=review




--- Comment #13 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 369128
  --> https://bugs.webkit.org/attachment.cgi?id=369128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369128&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:50
> +const CFStringRef WebCoreCGImagePropertyHEICSUnclampedDelayTime =
CFSTR("UnclampedDelayTime");

This is unused.

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:367
> +	       if (CFNumberRef num =
(CFNumberRef)CFDictionaryGetValue(heicsProperties,
WebCoreCGImagePropertyHEICSDictionary))

Is the property name for the number value really also
WebCoreCGImagePropertyHEICSDictionary? It seems like maybe this was supposed to
be WebCoreCGImagePropertyHEICSUnclampedDelayTime?